Hi Martin,
Am Mittwoch, den 27.03.2013, 12:54 +0100 schrieb Martin Fuzzey:
> Hi Philipp,
>
> On 26/03/13 15:13, Philipp Zabel wrote:
>
> > +static void imx_ldb_encoder_disable(struct drm_encoder *encoder)
> > +{
> > + struct imx_ldb_channel *imx_ldb_ch = enc_to_imx_ldb_ch(encoder);
> > + struct imx_ldb *ldb = imx_ldb_ch->ldb;
> > +
> > + if (gpio_is_valid(imx_ldb_ch->enable_gpio))
> > + gpio_set_value(imx_ldb_ch->enable_gpio, 0);
> >
> I get a compile error here:
> drivers/staging/imx-drm/imx-ldb.c: In function ‘imx_ldb_encoder_disable’:
> drivers/staging/imx-drm/imx-ldb.c:283:2: error: implicit declaration of
> function ‘gpio_is_valid’ [-Werror=implicit-function-declaration]
> drivers/staging/imx-drm/imx-ldb.c:283:30: error: ‘struct
> imx_ldb_channel’ has no member named ‘enable_gpio’
> drivers/staging/imx-drm/imx-ldb.c:284:3: error: implicit declaration of
> function ‘gpio_set_value’ [-Werror=implicit-function-declaration]
> drivers/staging/imx-drm/imx-ldb.c:284:28: error: ‘struct
> imx_ldb_channel’ has no member named ‘enable_gpio’
>
> Adding #include <linux/gpio.h> fixes that but gives another error:
> drivers/staging/imx-drm/imx-ldb.c: In function ‘imx_ldb_encoder_disable’:
> drivers/staging/imx-drm/imx-ldb.c:284:30: error: ‘struct
> imx_ldb_channel’ has no member named ‘enable_gpio’
> drivers/staging/imx-drm/imx-ldb.c:285:28: error: ‘struct
> imx_ldb_channel’ has no member named ‘enable_gpio’
>
> Commenting out the block gives a working driver.
thank you for pointing this out, the GPIO handling shouldn't have leaked
into this patch series.
regards
Philipp
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
