Re: [PATCH 00/22] staging: comedi: s626: cleanup driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2013-03-22 22:53, H Hartley Sweeten wrote:
Simplify the handling of the three digital i/o subdevices.

Split up the interrupt handler so it's easier to understand and
maintain.

Remove a number of macros that rely on having a local variable with
a "magic" name.

Remove a bunch of casts that were causing some sparse warnings.

Cleanup the digital i/o subdevice functions.

Tidy up the subdevice init in the attach function.

This driver still needs more cleanup but I need to locate a register
programming manual for it...

As luck would have it, I just spent the last couple of days before the weekend cleaning up this driver. Looks like you beat me to it. Oh well!

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux