On Tuesday, March 26, 2013 1:34 PM, Ian Abbott wrote: > On 26/03/2013 18:38, H Hartley Sweeten wrote: >> On Monday, March 25, 2013 11:46 AM, Greg Kroah-Hartman wrote: >>> On Fri, Mar 22, 2013 at 03:57:40PM -0700, H Hartley Sweeten wrote: >>>> This macro relies on a local variable having a specific name. Replace >>>> it with a new helper function, s626_mc_disable(). >>>> >>>> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> >>>> Cc: Ian Abbott <abbotti@xxxxxxxxx> >>>> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >>>> --- >>>> drivers/staging/comedi/drivers/s626.c | 20 +++++++++++++------- >>>> 1 file changed, 13 insertions(+), 7 deletions(-) >>> >>> I've applied this series up to, and including, this one, care to resend >>> the rest after fixing the problems that Dan pointed out? >> >> Greg, >> >> I just posted the updated series with the issues addressed. >> >> [PATCH 00/12] staging: comedi: s626: cleanup driver part 2 > > But patch 04 won't do the right thing. Patch 4 or Patch 5? Your previous comment was for 5/12. Regards, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel