On Friday, March 15, 2013 6:16 AM, Ian Abbott wrote: > Rather than overloading the semantics of the `iobase` member of `struct > comedi_device` to indicate whether a call to `comedi_pci_enable()` was > successful or not, introduce a new member `ioenabled` for this purpose, > managed by `comedi_pci_enable()` and `comedi_pci_disable()` themselves > (patch 3). This allows some unneeded settings of the `iobase` member to > be removed from a few drivers (patch 4). > > To save a few bytes in `struct comedi_device`, change some members of > type `int` used as boolean flags to 1-bit bit-fields of type `bool` > (patches 1 and 2). > > 1) staging: comedi: make 'dev->attached' a bool bit-field > 2) staging: comedi: make 'in_request_module' a bool bit-field > 3) staging: comedi: add 'ioenabled' flag to device > 4) staging: comedi: remove unneeded settings of `dev->iobase` > > Patch 3 may conflict with H Hartley Sweeten's work a little. For now, Greg dropped my patches that would conflict. There shouldn't be any issues. I'll rework mine after this gets in. For all four patches: Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
