On Thu, Mar 14, 2013 at 11:17:04AM +0100, Paul Bolle wrote: > 1) This patch is rather hard to review. That is because the "depends on" > line is rather hard to read. Perhaps the easiest way to review is to do > git grep -n "\bUSB_FILE_STORAGE\(_TEST\)\?\b" > > before and after applying this patch. But that doesn't catch possible > other, unwanted, changes. Maybe we need to split up the "depends on" > line before removing these two negative entries. Your patch is fine as is, but if you wanted to send a follow on patch to break the depend mess into separate lines, that would also be welcome. :) Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
