> -----Original Message----- > From: Tomas Hozza [mailto:thozza@xxxxxxxxxx] > Sent: Wednesday, March 13, 2013 9:14 AM > To: gregkh@xxxxxxxxxxxxxxxxxxx > Cc: KY Srinivasan; jasowang@xxxxxxxxxx; Haiyang Zhang; > devel@xxxxxxxxxxxxxxxxxxxxxx; Tomas Hozza > Subject: [PATCH 2/3] tools: hv: daemon setsockopt should use options macros > > HyperV daemon should use macros for option values when calling setsockopt. > Using specific numeric values instead of macros is confusing. > > Signed-off-by: Tomas Hozza <thozza@xxxxxxxxxx> Acked-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > --- > tools/hv/hv_kvp_daemon.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c > index 908a612..704a0f9 100644 > --- a/tools/hv/hv_kvp_daemon.c > +++ b/tools/hv/hv_kvp_daemon.c > @@ -102,6 +102,10 @@ static struct utsname uts_buf; > #define MAX_FILE_NAME 100 > #define ENTRIES_PER_BLOCK 50 > > +#ifndef SOL_NETLINK > +#define SOL_NETLINK 270 > +#endif > + > struct kvp_record { > char key[HV_KVP_EXCHANGE_MAX_KEY_SIZE]; > char value[HV_KVP_EXCHANGE_MAX_VALUE_SIZE]; > @@ -1407,7 +1411,7 @@ netlink_send(int fd, struct cn_msg *msg) > > int main(void) > { > - int fd, len, sock_opt; > + int fd, len, nl_group; > int error; > struct cn_msg *message; > struct pollfd pfd; > @@ -1452,8 +1456,8 @@ int main(void) > close(fd); > exit(EXIT_FAILURE); > } > - sock_opt = CN_KVP_IDX; > - setsockopt(fd, 270, 1, &sock_opt, sizeof(sock_opt)); > + nl_group = CN_KVP_IDX; > + setsockopt(fd, SOL_NETLINK, NETLINK_ADD_MEMBERSHIP, &nl_group, > sizeof(nl_group)); > /* > * Register ourselves with the kernel. > */ > -- > 1.8.1.4 > > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
