On Mon, Mar 11, 2013 at 5:04 PM, Joe Perches <joe@xxxxxxxxxxx> wrote: ... > I think it's odd to use pr_info in binder_debug. > Why not use KERN_DEBUG or pr_debug/dynamic_debugging? > > #define binder_debug(mask, x...) \ > do { \ > if (binder_debug_mask & mask) \ > pr_info(x); \ > } while (0) > > This code predates the dynamic_debugging framework, but I also find it easier to use so I would be reluctant to convert it unless there is an easy way to match the current behavior. It is useful to turn a set of debug messages on by class and to have some classes on by default. -- Arve Hjønnevåg _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel