On Mon, Mar 11, 2013 at 6:46 AM, Mark Einon <mark.einon@xxxxxxxxx> wrote: > On 21 February 2013 17:37, Devendra Naga <devendra.aaru@xxxxxxxxx> wrote: >> should be err < 0 instead of if (err) which actually the read register >> value can be a positive number >> > > Acked-by: Mark Einon <mark.einon@xxxxxxxxx> Thanks mark! > >> Signed-off-by: Devendra Naga <devendra.aaru@xxxxxxxxx> >> --- > > Must of missed this in my inbox...done. > > Mark > >> drivers/staging/et131x/et131x.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c >> index 84bbcd4..6bd4a79 100644 >> --- a/drivers/staging/et131x/et131x.c >> +++ b/drivers/staging/et131x/et131x.c >> @@ -607,7 +607,7 @@ static int eeprom_write(struct et131x_adapter *adapter, u32 addr, u8 data) >> */ >> >> err = eeprom_wait_ready(pdev, NULL); >> - if (err) >> + if (err < 0) >> return err; >> >> /* >> @@ -730,7 +730,7 @@ static int eeprom_read(struct et131x_adapter *adapter, u32 addr, u8 *pdata) >> */ >> >> err = eeprom_wait_ready(pdev, NULL); >> - if (err) >> + if (err < 0) >> return err; >> /* >> * Write to the LBCIF Control Register: bit 7=1, bit 6=0, bit 3=0, >> -- >> 1.8.1.2 >> _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
