On Tuesday, March 05, 2013 12:58 PM, Ian Abbott wrote: > On 05/03/2013 17:17, Ian Abbott wrote: >> From: Frank Mori Hess <fmh6jj@xxxxxxxxx> >> >> New comedi driver for Advantech PCI-1724U with modifications by Ian >> Abbott <abbotti@xxxxxxxxx>. >> >> Signed-off-by: Ian Abbott <abbotti@xxxxxxxxx> >> --- >> v2: Fix missing `if (ret)` after call to `comedi_alloc_subdevices()`. >> v3: Melded the 13 patches for v2 into a single patch. > > This will be incompatible with H Hartley Sweeten's change to the > comedi_pci_auto_config(), so best skip v3 for now and I'll knock out a > v4 incorporating Hartley's changes once that has been accepted. > > (I haven't actually gone through them all yet!) Ian, The amplc drivers still do the boardinfo searching. Those drivers are a bit of a hybrid due to the dual ISA/PCI support. I'm not sure how you want to handle those. 1) Split the "bus" specific support out as separate modules with a "core" module with all the common code. The das08 driver is setup this way. 2) Split the boardinfo for the PCI devices out of the boardinfo passed in the comedi_driver. The ISA devices then would be detected in the legacy fashion and the PCI devices would be auto-detected and the boardinfo enum passed In the pci_device_id driver_data. 3) Some other way.... 4) Leave it as-is... Your drivers, your choice.. ;-) Regards, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
