Re: [PATCH 00/13] staging: comedi: new driver for Advantech PCI-1724U

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2013-03-05 14:01, Dan Carpenter wrote:
On Tue, Mar 05, 2013 at 11:36:22AM +0000, Ian Abbott wrote:
I was thinking of squashing these 13 patches (including the two v2
patches) into a single patch, since adding 13 patches for a single
new driver seems a bit much.  Is that a good idea or not?  Thanks.

It's a pretty normal thing to do.

I wish we had a better way to preserve authorship for bits that
get squashed in.  Btw, I sort of feel like the author tag should go
to Frank.  The first line of the email should be:

From: Frank Mori Hess <fmh6jj@xxxxxxxxx>

`cat ~/raw_email.txt | git am` will parse that correctly.

I agree that Frank should be credited as the author, but I'm worried about the commit message (written by me) looking a little odd if it's not signed off by the credited author! So I'll do as you suggest, sign it off myself and request a "Signed-off-by:" line from Frank.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux