On Fri, Feb 22, 2013 at 12:13:30PM +0100, Kurt Kanzenbach wrote:
> This patch fixes the following checkpatch error:
> -ERROR: do not use assignment in if condition
>
> Signed-off-by: Kurt Kanzenbach <ly80toro@xxxxxxxxxxxxx>
> ---
> drivers/staging/usbip/userspace/libsrc/names.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/usbip/userspace/libsrc/names.c b/drivers/staging/usbip/userspace/libsrc/names.c
> index a66f539..3b151df 100644
> --- a/drivers/staging/usbip/userspace/libsrc/names.c
> +++ b/drivers/staging/usbip/userspace/libsrc/names.c
> @@ -491,9 +491,11 @@ static void parse(FILE *f)
> while (fgets(buf, sizeof(buf), f)) {
> linectr++;
> /* remove line ends */
> - if ((cp = strchr(buf, 13)))
> + cp = strchr(buf, 13);
This is for another patch but 13 is '\r'
> + if (cp)
> *cp = 0;
> - if ((cp = strchr(buf, 10)))
> + cp = strchr(buf, 10);
and 10 is '\n'.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
