Re: [PATCH] staging/panel: Mark local functions as static (fix smatch warnings)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Peter Huewe <peterhuewe@xxxxxx> wrote:

> +static char old_keypad_profile[][4][9] = {
>  	{"S0", "Left\n", "Left\n", ""},
>  	{"S1", "Down\n", "Down\n", ""},
>  	{"S2", "Up\n", "Up\n", ""},

Things like this should likely be const also.  There are several here.

> -void panel_lcd_print(char *s)
> +static void panel_lcd_print(char *s)

const char *s maybe?

David
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux