This patch works but it's nasty to re-intialize "reg" inside both if else statements. Just do it once at the begining of the function. That means we would also delete the ininitialization from the if side of the if else statement: if (devpriv->model == VMK8061_MODEL) { - reg = VMK8061_DO_REG; tx_buf[0] = VMK8061_CMD_RD_DO; regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel