RE: [PATCH 1/5] staging: comedi: ni_daq_dio24: use comedi_pcmcia_{enable, disable}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday, February 07, 2013 12:43 AM, Dan Carpenter wrote:
> On Tue, Feb 05, 2013 at 06:15:20PM -0700, H Hartley Sweeten wrote:
>> -	ret = pcmcia_enable_device(link);
>> -	if (ret)
>> +	link->config_flags |= CONF_AUTO_SET_IO;
>> +	ret = comedi_pcmcia_enable(dev);
>>  		return ret;
>>  	dev->iobase = link->resource[0]->start;
>
> There is an if (ret) statement missing?  The last line is
> unreachable.

Thanks for noticing this. Removing the if (ret) was not intended.

Greg has already merged this into his staging tree. I will post a follow up
patch to fix it shortly.

Regards,
Hartley

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux