On Thu, Jan 31, 2013 at 11:45:15AM +0000, Ian Abbott wrote: > On 2013-01-30 19:09, H Hartley Sweeten wrote: > >On Wednesday, January 30, 2013 5:11 AM, Ian Abbott wrote: > >>On 2013-01-29 23:16, H Hartley Sweeten wrote: > >>>Split out the comedi core bus specific support code so it can be > >>>conditionally included in the build. Move the bus specific includes > >>>from the comedi headers to the individual drivers. > >>> > >>>Add comedi core support for auto attaching to comedi pcmcia drivers. > >>>Convert the cb_das16_cs, das08_cs, and ni_daq_700 drivers to use the > >>>auto_attach mechanism. The other comedi pcmcia drivers will be > >>>converted later, they all have pending patches that are being > >>>reviewed. > >>> > >>>Tidy up the remaining general purpose driver attach/detach functions. > >>> > >>>Move a couple comedi core internal function prototypes from comedidev.h > >>>to comedi_internal.h so they are not exported globally. > >> > >>There seems to be some horrible space/tab mismatches in these patches, > >>or at least the first one as that's where I'm currently stuck in > >>applying them locally. > > > >Found the whitespace issue. I had two trailing spaces In the comment block > >at the top of comedi_pci.c. > > > >The difference in comedidev.h because of your patch to simplify > >comedi_set_hw_dev() was causing patch 2/10 not to apply. Your patch > >also introduced some fuzz in my other patches. > > That wasn't really the problem I was having, as I'd already given up > by the second patch. The problem was that all the tabs in the first > two patches had been expanded to spaces. The remaining 8 patches > never had that problem! > > >I have rebased the series to Greg's staging-next branch and fixed the > >issues. I'm doing a build test now just to check. I'll repost the series > >shortly. > > Curiously, the first two patches in your reposted v2 series have the > same problem, and so do the ones in the confirmation emails from > Greg saying they've been added to the staging tree. The commits > themselves don't have expanded tabs, so maybe Greg worked some magic > before committing them. Perhaps something on your end is messing these up? _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
