On Tue, Jan 22, 2013 at 05:10:10PM +0000, Mark Einon wrote: > Dan Carpenter has pointed out that there are several sparse warnings > from et131x.c, listed below. This patch fixes all these errors. > > drivers/staging/et131x/et131x.c:1870:33: warning: incorrect type in assignment (different address spaces) > drivers/staging/et131x/et131x.c:1870:33: expected unsigned int [usertype] *num_des > drivers/staging/et131x/et131x.c:1870:33: got unsigned int [noderef] <asn:2>*<noident> > drivers/staging/et131x/et131x.c:1871:37: warning: incorrect type in assignment (different address spaces) > drivers/staging/et131x/et131x.c:1871:37: expected unsigned int [usertype] *full_offset > drivers/staging/et131x/et131x.c:1871:37: got unsigned int [noderef] <asn:2>*<noident> > drivers/staging/et131x/et131x.c:1872:33: warning: incorrect type in assignment (different address spaces) > drivers/staging/et131x/et131x.c:1872:33: expected unsigned int [usertype] *min_des > drivers/staging/et131x/et131x.c:1872:33: got unsigned int [noderef] <asn:2>*<noident> > drivers/staging/et131x/et131x.c:1873:33: warning: incorrect type in assignment (different address spaces) > drivers/staging/et131x/et131x.c:1873:33: expected unsigned int [usertype] *base_hi > drivers/staging/et131x/et131x.c:1873:33: got unsigned int [noderef] <asn:2>*<noident> > drivers/staging/et131x/et131x.c:1874:33: warning: incorrect type in assignment (different address spaces) > drivers/staging/et131x/et131x.c:1874:33: expected unsigned int [usertype] *base_lo > drivers/staging/et131x/et131x.c:1874:33: got unsigned int [noderef] <asn:2>*<noident> > drivers/staging/et131x/et131x.c:1876:33: warning: incorrect type in assignment (different address spaces) > drivers/staging/et131x/et131x.c:1876:33: expected unsigned int [usertype] *num_des > drivers/staging/et131x/et131x.c:1876:33: got unsigned int [noderef] <asn:2>*<noident> > drivers/staging/et131x/et131x.c:1877:37: warning: incorrect type in assignment (different address spaces) > drivers/staging/et131x/et131x.c:1877:37: expected unsigned int [usertype] *full_offset > drivers/staging/et131x/et131x.c:1877:37: got unsigned int [noderef] <asn:2>*<noident> > drivers/staging/et131x/et131x.c:1878:33: warning: incorrect type in assignment (different address spaces) > drivers/staging/et131x/et131x.c:1878:33: expected unsigned int [usertype] *min_des > drivers/staging/et131x/et131x.c:1878:33: got unsigned int [noderef] <asn:2>*<noident> > drivers/staging/et131x/et131x.c:1879:33: warning: incorrect type in assignment (different address spaces) > drivers/staging/et131x/et131x.c:1879:33: expected unsigned int [usertype] *base_hi > drivers/staging/et131x/et131x.c:1879:33: got unsigned int [noderef] <asn:2>*<noident> > drivers/staging/et131x/et131x.c:1880:33: warning: incorrect type in assignment (different address spaces) > drivers/staging/et131x/et131x.c:1880:33: expected unsigned int [usertype] *base_lo > drivers/staging/et131x/et131x.c:1880:33: got unsigned int [noderef] <asn:2>*<noident> > drivers/staging/et131x/et131x.c:1898:24: warning: incorrect type in argument 2 (different address spaces) > drivers/staging/et131x/et131x.c:1898:24: expected void volatile [noderef] <asn:2>*addr > drivers/staging/et131x/et131x.c:1898:24: got unsigned int [usertype] *base_hi > drivers/staging/et131x/et131x.c:1900:24: warning: incorrect type in argument 2 (different address spaces) > drivers/staging/et131x/et131x.c:1900:24: expected void volatile [noderef] <asn:2>*addr > drivers/staging/et131x/et131x.c:1900:24: got unsigned int [usertype] *base_lo > drivers/staging/et131x/et131x.c:1901:60: warning: incorrect type in argument 2 (different address spaces) > drivers/staging/et131x/et131x.c:1901:60: expected void volatile [noderef] <asn:2>*addr > drivers/staging/et131x/et131x.c:1901:60: got unsigned int [usertype] *num_des > drivers/staging/et131x/et131x.c:1902:39: warning: incorrect type in argument 2 (different address spaces) > drivers/staging/et131x/et131x.c:1902:39: expected void volatile [noderef] <asn:2>*addr > drivers/staging/et131x/et131x.c:1902:39: got unsigned int [usertype] *full_offset > drivers/staging/et131x/et131x.c:1910:24: warning: incorrect type in argument 2 (different address spaces) > drivers/staging/et131x/et131x.c:1910:24: expected void volatile [noderef] <asn:2>*addr > drivers/staging/et131x/et131x.c:1910:24: got unsigned int [usertype] *min_des > drivers/staging/et131x/et131x.c:2583:32: warning: incorrect type in assignment (different address spaces) > drivers/staging/et131x/et131x.c:2583:32: expected unsigned int [usertype] *offset > drivers/staging/et131x/et131x.c:2583:32: got unsigned int [noderef] <asn:2>*<noident> > drivers/staging/et131x/et131x.c:2585:32: warning: incorrect type in assignment (different address spaces) > drivers/staging/et131x/et131x.c:2585:32: expected unsigned int [usertype] *offset > drivers/staging/et131x/et131x.c:2585:32: got unsigned int [noderef] <asn:2>*<noident> > drivers/staging/et131x/et131x.c:2602:24: warning: incorrect type in argument 2 (different address spaces) > drivers/staging/et131x/et131x.c:2602:24: expected void volatile [noderef] <asn:2>*addr > drivers/staging/et131x/et131x.c:2602:24: got unsigned int [usertype] *offset > drivers/staging/et131x/et131x.c:4093:13: warning: symbol 'et131x_isr' was not declared. Should it be static? > > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Signed-off-by: Mark Einon <mark.einon@xxxxxxxxx> > --- > > Hi Greg, > > I think you've missed this patch, as you've applied all other et131x patches sent after it... Crap, sorry about that, I somehow dropped it, my fault. Thanks for resending it. greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel