Separate this driver from the addi-data "common" code and remove all the bloat. Introduce a new helper module to support the watchdog subdevice that is common in many of the addi-data drivers. Use that module in the addi_apci_2032 and addi_apci_2200 drivers. v2: fix [17/23] staging: comedi: addi_apci_2200: use addi_watchdog module 1) the addi_apci2200 driver needs to select the addi_watchdog module 2) pass the correct subdevice to addi_watchdog_cleanup() H Hartley Sweeten (23): staging: comedi: addi_apci_2200: separate from addi_common.c staging: comedi: addi_apci_2200: board does not have ttl i/o staging: comedi: addi_apci_2200: board does not have analog outputs staging: comedi: addi_apci_2200: board does not have analog inputs staging: comedi: addi_apci_2200: remove eeprom support code staging: comedi: addi_apci_2200: absorb i_APCI2200_Reset() staging: comedi: addi_apci_2200: simplify the PCI bar reading staging: comedi: addi_apci_2200: remove unnecessary info from boardinfo staging: comedi: addi_apci_2200: remove devpriv->iobase usage staging: comedi: addi_apci_2200: don't read the unused PCI bars staging: comedi: addi_apci_2200: remove use of devpriv->s_EeParameters staging: comedi: addi_apci_2200: remove interrupt support code staging: comedi: addi_apci_2200: cleanup digital input subdevice staging: comedi: addi_apci_2200: cleanup digital output subdevice staging: comedi: introduce addi_watchdog driver staging: comedi: addi_apci_2032: use addi_watchdog module staging: comedi: addi_apci_2200: use addi_watchdog module staging: comedi: addi_apci_2200: remove devpriv allocation staging: comedi: addi_apci_2200: remove unnecessary boardinfo staging: comedi: addi_apci_2200: remove unnecessary include staging: comedi: addi_apci_2200: add missing copyright comment staging: comedi: addi_apci_2200: only allocate needed subdevices staging: comedi: addi_apci_2200: change the MODULE_DESCRIPTION drivers/staging/comedi/Kconfig | 9 + drivers/staging/comedi/drivers/Makefile | 1 + .../comedi/drivers/addi-data/hwdrv_apci2200.c | 263 --------------------- drivers/staging/comedi/drivers/addi_apci_2032.c | 110 +-------- drivers/staging/comedi/drivers/addi_apci_2200.c | 178 +++++++++++--- drivers/staging/comedi/drivers/addi_watchdog.c | 172 ++++++++++++++ drivers/staging/comedi/drivers/addi_watchdog.h | 10 + 7 files changed, 343 insertions(+), 400 deletions(-) delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_apci2200.c create mode 100644 drivers/staging/comedi/drivers/addi_watchdog.c create mode 100644 drivers/staging/comedi/drivers/addi_watchdog.h -- 1.8.0 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel