[PATCH 2/4] staging: comedi: comedi_buf: remove unreachable dev_warn in comedi_buf_munge()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Due to the 'while(count < num_bytes)' the computed 'block_size' will
always be a value greater than 0.

Remove the unreachable dev_warn and the (block_size < 0) test.

Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
Cc: Ian Abbott <abbobbi@xxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
 drivers/staging/comedi/comedi_buf.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/staging/comedi/comedi_buf.c b/drivers/staging/comedi/comedi_buf.c
index 7d516a0..9d11f416 100644
--- a/drivers/staging/comedi/comedi_buf.c
+++ b/drivers/staging/comedi/comedi_buf.c
@@ -215,13 +215,6 @@ static unsigned int comedi_buf_munge(struct comedi_async *async,
 			int block_size = num_bytes - count;
 			unsigned int buf_end;
 
-			if (block_size < 0) {
-				dev_warn(s->device->class_dev,
-					"%s: %s: bug! block_size is negative\n",
-					__FILE__, __func__);
-				break;
-			}
-
 			buf_end = async->prealloc_bufsz - async->munge_ptr;
 			if (block_size > buf_end)
 				block_size = buf_end;
-- 
1.8.0

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux