This would be easier to review if it were broken up into separate patches. 1) There are superflous white spaces changes 2) Changes to the copyright 3) pr_warning => pr_warn 4) The REG_READ and REG_WRITE macros are now inline functions 5) KBUILD_MODNAME is used instead of DRV_NAME 6) It now uses the video_drvdata() function 7) Lots of comments deleted. For exmple, vidioc_enum_fmt_vid_cap() didn't change. Just the comments were deleted. 8) Comments added for existing code. 9) Other behavior changes not related to using videobuf2 like in vidioc_try_fmt_vid_cap(). 10) etc... If all the uninteresting changes are in separate patches it makes the complicated stuff much shorter and easier to review. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
