RE: [PATCH 2/2] Staging: comedi: addi_common.h: checkpatch.pl fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday, January 07, 2013 3:40 PM, Greg KH wrote:
> On Sat, Jan 05, 2013 at 06:12:55PM +0400, Lijo Antony wrote:
>> Reduced line lengths to 80 chars by removing extra spaces.
>> 
>> Signed-off-by: Lijo Antony <lijo.kernel@xxxxxxxxx>
>> ---
>>  .../staging/comedi/drivers/addi-data/addi_common.h |   20 ++++++++++----------
>>  1 file changed, 10 insertions(+), 10 deletions(-)

<snip>

> As you didn't do this for all fields in the structure, it's not really
> worth doing it for just these, right?
>
> The proper thing to do is use kerneldoc format and document it all at
> the top of the structure, care to do that instead?

Hopefully I will soon get the rest of the addi-data drivers split off of the
addi_common stuff. This will effectively remove this header file so I'm
not sure it's worth making patches against it.

Regards,
Hartley

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux