Re: [PATCH 01/11] staging: comedi: separate out comedi_buf_* functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 21, 2012 at 09:36:50AM -0700, H Hartley Sweeten wrote:
> Create a new file, comedi_buf.c, to hold all the comedi_async buffer
> functions. Currently they are all in drivers.c and really don't have
> any association with that source file.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: Ian Abbott <abbobbi@xxxxxxxxx>
> ---
>  drivers/staging/comedi/Makefile     |   3 +-
>  drivers/staging/comedi/comedi_buf.c | 421 ++++++++++++++++++++++++++++++++++++
>  drivers/staging/comedi/drivers.c    | 398 ----------------------------------
>  3 files changed, 423 insertions(+), 399 deletions(-)
>  create mode 100644 drivers/staging/comedi/comedi_buf.c
> 
> diff --git a/drivers/staging/comedi/Makefile b/drivers/staging/comedi/Makefile
> index f895c0c..51816c3 100644
> --- a/drivers/staging/comedi/Makefile
> +++ b/drivers/staging/comedi/Makefile
> @@ -1,4 +1,5 @@
> -comedi-y			:= comedi_fops.o range.o drivers.o
> +comedi-y			:= comedi_fops.o range.o drivers.o \
> +				   comedi_buf.o
>  comedi-$(CONFIG_PROC_FS)	+= proc.o
>  comedi-$(CONFIG_COMPAT)		+= comedi_compat32.o

This patch fails to apply as you changed the Makefile on a previous
patch you sent me.

And, I'm not quite sure what the status is of all of these patches in
the series, was there ever a consensus?

So, if they are still needed, and work properly, care to redo them
against my latest tree and resend?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux