On Fri, Jan 04, 2013 at 10:46:22AM +0800, wwang wrote: > 于 2013年01月03日 20:25, Dan Carpenter 写道: > > On Fri, Dec 28, 2012 at 10:41:28AM +0800, wei_wang@xxxxxxxxxxxxxx wrote: > >> From: Wei WANG <wei_wang@xxxxxxxxxxxxxx> > >> > >> Realtek PCIe card reader only supports 32bit DMA > >> > > Is this a bugfix? If so what does the bug look like? > > > > regards, > > dan carpenter > > > Hi Dan: > > No, this is not a bugfix. In default, the kernel will allocate 32bit > address for DMA. This declaration can improve the readability. > Ah ok. Really none of the things I mentioned were stuff that prevented the patch from being merged or couldn't be fixed in follow on patches. The thing is that the commit message should always say why a patch is needed. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel