Re: [PATCH 07/18] Staging: bcm: Replace ULONG with unsigned long in Protocol.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 03, 2013 at 01:38:11PM -0500, Kevin McKinney wrote:
> On Thu, Jan 3, 2013 at 9:01 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> > On Sat, Dec 22, 2012 at 02:27:45PM -0500, Kevin McKinney wrote:
> >> This patch replaces "ULONG" with "unsigned long"
> >> in Protocol.h
> >>
> >> Signed-off-by: Kevin McKinney <klmckinney1@xxxxxxxxx>
> >> ---
> >>  drivers/staging/bcm/Protocol.h |    4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/staging/bcm/Protocol.h b/drivers/staging/bcm/Protocol.h
> >> index 040689b..7070ce6 100644
> >> --- a/drivers/staging/bcm/Protocol.h
> >> +++ b/drivers/staging/bcm/Protocol.h
> >> @@ -113,8 +113,8 @@ typedef enum _E_SERVICEFLOW_CS_SPEC_ {
> >>  typedef struct _TCP_HEADER {
> >>       unsigned short usSrcPort;
> >>       unsigned short usDestPort;
> >> -     ULONG  ulSeqNumber;
> >> -     ULONG  ulAckNumber;
> >> +     unsigned long  ulSeqNumber;
> >> +     unsigned long  ulAckNumber;
> >
> > BCM doesn't work on 64 bits.  This might be one of the reasons (we
> > already looked at another problem earlier).  I'm pretty sure that
> > the SeqNumber and AckNumber from the TCP header are both 32 bits.
> >
> > I can't test this code myself.
> 
> Yeah, this is one struct that I was looking at to address the 64 bit
> problem.  I will change these to 32 bit int and have these changes
> tested.  If it works, I will submit another patch.

Thanks.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux