Remove all the forward declarations.
Move the low-level struct device drvdata (struct comedi_device_file_info)
internal to this module and don't expose it globally.
Don't allow direct access to the spin_lock protected subdevice runflags.
Provide an exported helper function for the one driver module (ni_mio_common)
that checks to see if the subdevice is running a command. Provide a couple
other internal helper functions to help clarify the code.
Refactor the code a bit so the MODULE_* information and module_{init,exit}
code is at the end of the file.
Do a bit of housekeeping of the rest of the code.
H Hartley Sweeten (26):
staging: comedi: comedi_fops: remove forward declarations
staging: comedi: don't expose comedi_get_{read,write}_subdevice
staging: comedi: comedi_fops: introduce comedi_dev_from_minor()
staging: comedi: use comedi_dev_from_minor()
staging: comedi: comedi_fops: don't export comedi_get_device_file_info()
staging: comedi: don't expose struct comedi_device_file_info
staging: comedi: comedi_fops: rename struct comedi_device_file_info
staging: comedi: comedi_fops: rename comedi_get_device_file_info()
staging: comedi: comedi_fops: rename comedi_{read,write}_subdevice()
staging: comedi: comedi_fops: cleanup do_devinfo_ioctl()
staging: comedi: comedi_fops: cleanup comedi_poll()
staging: comedi: comedi_fops: remove the goto's in comedi_read()
staging: comedi: comedi_fops: remove the goto's in comedi_write()
staging: comedi: comedi_fops: move the MODULE_* information to EOF
staging: comedi: comedi_fops: move the module_{init,exit} functions to EOF
staging: comedi: comedi_fops: move comedi_cleanup_legacy_minors()
staging: comedi: comedi_fops: fix a number of sizeof(struct foo) forms
staging: comedi: comedi_fops: move comedi_get_subdevice_runflags()
staging: comedi: comedi_fops: introduce comedi_is_subdevice_running()
staging: comedi: use comedi_is_subdevice_running()
staging: comedi: comedi_fops: don't export comedi_get_subdevice_runflags()
staging: comedi: comedi_fops: introduce comedi_is_subdevice_in_error()
staging: comedi: comedi_fops: introduce comedi_is_subdevice_idle()
staging: comedi: comedi_fops: cleanup comedi_{read,write}_subdevice()
staging: comedi: comedi_fops: cleanup comedi_mmap()
staging: comedi: comedi_fops: use kzalloc in comedi_alloc_subdevice_minor()
drivers/staging/comedi/comedi_fops.c | 774 ++++++++++-----------
drivers/staging/comedi/comedidev.h | 32 +-
drivers/staging/comedi/drivers.c | 11 +-
drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
.../staging/comedi/kcomedilib/kcomedilib_main.c | 8 +-
drivers/staging/comedi/proc.c | 7 +-
6 files changed, 387 insertions(+), 447 deletions(-)
--
1.8.0
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
