On Mon, Dec 17, 2012 at 02:38:01PM +0100, Sebastian Wankerl wrote:
> From: Sebastian Wankerl <sisewank@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
>
> Signed-off-by: Sebastian Wankerl <sisewank@xxxxxxxxxxxxx>
> Signed-off-by: Sebastian Ehrenfels <qi50dube@xxxxxxxxxxxxx>
>
> ---
> drivers/staging/wlan-ng/prism2mgmt.c | 25 +++++++++++++++----------
> 1 file changed, 15 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> index 4efa9bc..62b94b0 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.c
> +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> @@ -415,11 +415,14 @@ int prism2mgmt_scan_results(wlandevice_t *wlandev, void *msgp)
> break;
>
> #define REQBASICRATE(N) \
> - if ((count >= N) && DOT11_RATE5_ISBASIC_GET(item->supprates[(N)-1])) { \
> - req->basicrate ## N .data = item->supprates[(N)-1]; \
> - req->basicrate ## N .status = \
> - P80211ENUM_msgitem_status_data_ok; \
> - }
> + do { \
> + if ((count >= N) && DOT11_RATE5_ISBASIC_GET( \
> + item->supprates[(N)-1])) { \
This is a very confusing way to indent. The proper way is:
do { \
if (count >= N && \
DOT11_RATE5_ISBASIC_GET(item->supprates[(N)-1])) { \
The "DOT11_RATE5_ISBASIC_GET(item->supprates[(N)-1])" call should be
on one line if possible.
The start 'c' in count and the 'D' in DOT11_ should be in the same
column. You will need to add some space characters to make this
work.
> + req->basicrate ## N .data = item->supprates[(N)-1]; \
> + req->basicrate ## N .status = \
> + P80211ENUM_msgitem_status_data_ok; \
> + } \
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
