On Mon, Dec 10, 2012 at 03:49:46AM -0800, Joe Perches wrote: > On Mon, 2012-12-10 at 12:46 +0300, Dan Carpenter wrote: > > On Sun, Dec 09, 2012 at 10:15:10AM +0000, Przemo Firszt wrote: > > > Replace leading spaces with tab > [] > > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > [] > > > static int r871x_set_wpa_ie(struct _adapter *padapter, char *pie, > > > - unsigned short ielen) > > > + unsigned short ielen) > > > > The original version is better because it lines up correctly. > > > > Checkpatch doesn't complain for me so I'm not sure what the story is > > here. > > Parenthesis alignment isn't described in CodingStyle. > It's maintainer's preference. Whether or not it should > be is a different question. > > checkpatch parenthesis alignment of arguments checks are > emitted only when adding --strict to the command line. > Even with --strict checkpatch.pl is fine with the original code. I don't know any subsystems where the new version would be prefered over the original version. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
