Re: [PATCH] staging: comedi: pass through context for USB/PCI auto attach

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2012-12-04 14:10, Dan Carpenter wrote:
You guys have taken some unused code and made it more and more
flexible.  I think you should just delete the parameter.  When you
need a parameter, then we can add it back.  If you need two
parameters then we can add two of them.

The one current driver that might have a use for it is the vmk80xx driver. That one has `driver_info` values in its USB device table, but the driver currently uses that in its USB probe routine to allocate and initialize a load of stuff before it calls comedi_usb_auto_config(). If the driver was changed to remove the manual attachment functionality (the `attach` handler), I think all that stuff could be moved to the `auto_attach` handler, in which case setting the context parameter to the `driver_info` value would be useful.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux