Re: [PATCH] staging: comedi: rework the comedi_auto_config 'context'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2012-11-30 22:19, H Hartley Sweeten wrote:
The 'context' passed to comedi_auto_config() is currently an unsigned
long value. This value is passed to the (*auto_attach)() function of a
comedi driver. Currently none of the comedi drivers use the 'context'.

The only callers of comedi_auto_config() are the two inline wrappers
comedi_pci_auto_config() and comedi_usb_auto_config(). Both of these
pass a 'context' of 0.

Change the 'context' to a const void * and rework the auto_config code
and the pci/usb drivers so that the 'context' passed is the struct
{pci,usb}_device_id * that is passed to the {pci,usb}_driver (*probe)()
function.

Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
Cc: Ian Abbott <abbotti@xxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

I'm not sure what you're planning to do with this, but maybe it would be better to pass the `driver_data` from the `struct pci_device_id` or the `driver_info` from the `struct usb_device_id` and change the type of the context to `kernel_ulong_t`?

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux