Re: [PATCH 1/2] staging: ft1000: replace some spaces with tabs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 26, 2012 at 2:37 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Sat, Nov 24, 2012 at 04:59:51AM -0500, Devendra Naga wrote:
>> there are spaces at the starting of the line, replace with tabs
>>
>> Signed-off-by: Devendra Naga <devendra.aaru@xxxxxxxxx>
>> ---
>>  drivers/staging/ft1000/ft1000-usb/ft1000_proc.c |   14 +++++++-------
>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_proc.c b/drivers/staging/ft1000/ft1000-usb/ft1000_proc.c
>> index 5ae3967..b282cd6 100644
>> --- a/drivers/staging/ft1000/ft1000-usb/ft1000_proc.c
>> +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_proc.c
>> @@ -146,24 +146,24 @@ ft1000ReadProc(char *page, char **start, off_t off, int count, int *eof,
>>
>>       len = 0;
>>       PUTM_TO_PAGE(len, page, "Connection Time: %02ld:%02ld:%02ld\n",
>> -                     ((delta / 3600) % 24), ((delta / 60) % 60), (delta % 60));
>> +             ((delta / 3600) % 24), ((delta / 60) % 60), (delta % 60));
>>       PUTM_TO_PAGE(len, page, "Connection Time[s]: %ld\n", delta);
>>       PUTM_TO_PAGE(len, page, "Asic ID: %s\n",
>> -             (info->AsicID) ==
>> -             ELECTRABUZZ_ID ? "ELECTRABUZZ ASIC" : "MAGNEMITE ASIC");
>> +     (info->AsicID) ==
>> +     ELECTRABUZZ_ID ? "ELECTRABUZZ ASIC" : "MAGNEMITE ASIC");
>
> These aren't indented correctly.  The original was better.  It
> should be:
>
>         PUTM_TO_PAGE(len, page, "Asic ID: %s\n",
>                      info->AsicID == ELECTRABUZZ_ID ?
>                      "ELECTRABUZZ ASIC" : "MAGNEMITE ASIC");


i will fix it Dan, sorry for the very late response, will send another version.

>
> regargs,
> dan carpenter
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux