On Fri, Nov 30, 2012 at 10:19:06AM +0100, walter harms wrote: > > if (press_str[0]) > > keypad_send_key(press_str, > > - sizeof(press_str)); > > + sizeof(input->u.kbd.press_str)); > > } > yep, this looks like the original intention. > NTL i would like to question the use of press_str and friends. > Moving the if (press_str[0]) into keypad_send_key() seems > more sensible. > > just my two cents, > Greg had already applied my patch by the you sent this email. What you're saying sounds like it should be a good cleanup, but when I actually look at it, the callers still have to test repeat_str[0] so it's not as useful as one would hope. Really this stuff is really confusing. I'm not sure what is actually stored in press_str. Is it a pointer or just chars? If it's a pointer then why are we only checking the first bit instead of checking the pointer? I think it's characters but why is it declared as "char press_str[sizeof(void *) + sizeof(int)];"? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
