On 11/29/2012 06:43 PM, Dan Carpenter wrote:
On Thu, Nov 29, 2012 at 04:07:00PM +0100, Kurt Kanzenbach wrote:
Fixed a coding style issue. Replaced all
c99 comments by c89 ones. Therefore it was
required to reindent some lines.
Delete the commented out code.
Signed-off-by: Kurt Kanzenbach<shifty91@xxxxxxxxx>
Signed-off-by: Stefan Reif<reif_stefan@xxxxxx>
I don't understand these signed-of-bys. Stefan reviewed the code
and Acked it? In that case, it should be Acked-by:. Unless it
passed through his hands some how then it shouldn't be
Signed-off-by.
---
drivers/staging/keucr/usb.c | 100 ++++++++++++++++++++++++-------------------
1 file changed, 55 insertions(+), 45 deletions(-)
diff --git a/drivers/staging/keucr/usb.c b/drivers/staging/keucr/usb.c
index 55a0b82..b3a11e1 100644
--- a/drivers/staging/keucr/usb.c
+++ b/drivers/staging/keucr/usb.c
@@ -42,19 +42,22 @@ static int eucr_suspend(struct usb_interface *iface, pm_message_t message)
/* Wait until no command is running */
mutex_lock(&us->dev_mutex);
- //US_DEBUGP("%s\n", __func__);
+ /* US_DEBUGP("%s\n", __func__); */
Delete these.
+ /* us->Power_IsResum = true; */
+ /* us->SD_Status.Ready = 0; */
Delete.
-//----- eucr_pre_reset() ---------------------
+/* ----- eucr_pre_reset() --------------------- */
Delete.
etc.
regards,
dan carpenter
I will delete the commented out code and resend.
Thanks,
Kurt
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
