Re: [PATCH 02/14] Staging: bcm: Properly format and remove comments as needed in nvm.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 29, 2012 at 11:22:42PM -0500, Kevin McKinney wrote:
> @@ -31,48 +30,28 @@ typedef struct _FLASH_SECTOR_INFO
>  typedef struct _FLASH_CS_INFO
>  {

>  	B_UINT32 MagicNumber;
> -	// let the magic number be 0xBECE-F1A5 - F1A5 for "flas-h"

That's sort of useful to know how the magic number is formed.

> -	// MSC Timeout after reset to switch from MSC to NW Mode
>  	B_UINT32 MassStorageTimeout;

This one as well is useful I think.

> -	// NO Data Activity timeout to switch from MSC to NW Mode
>  	B_UINT32 CDLessInactivityTimeout;

This one as well, perhaps.

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux