> -----Original Message----- > From: Tomas Hozza [mailto:thozza@xxxxxxxxxx] > Sent: Monday, November 12, 2012 3:55 AM > To: gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx; > jasowang@xxxxxxxxxx; KY Srinivasan; ben@xxxxxxxxxxxxxxx > Cc: Tomas Hozza > Subject: [PATCH 3/3] tools/hv: Fix permissions of created directory and files > > From: Ben Hutchings <ben@xxxxxxxxxxxxxxx> > > It's silly to create directories without execute permission, or to > give permissions to 'other' but not the group-owner. > > Write the permissions in octal and 'ls -l' format since these are much > easier to read than the named macros. > > Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx> > Signed-off-by: Tomas Hozza <thozza@xxxxxxxxxx> Acked-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > --- > tools/hv/hv_kvp_daemon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c > index a581b3f..17703c7 100644 > --- a/tools/hv/hv_kvp_daemon.c > +++ b/tools/hv/hv_kvp_daemon.c > @@ -236,7 +236,7 @@ static int kvp_file_init(void) > int alloc_unit = sizeof(struct kvp_record) * ENTRIES_PER_BLOCK; > > if (access(KVP_CONFIG_LOC, F_OK)) { > - if (mkdir(KVP_CONFIG_LOC, S_IRUSR | S_IWUSR | S_IROTH)) { > + if (mkdir(KVP_CONFIG_LOC, 0755 /* rwxr-xr-x */)) { > syslog(LOG_ERR, " Failed to create %s", > KVP_CONFIG_LOC); > exit(EXIT_FAILURE); > } > @@ -247,7 +247,7 @@ static int kvp_file_init(void) > records_read = 0; > num_blocks = 1; > sprintf(fname, "%s/.kvp_pool_%d", KVP_CONFIG_LOC, i); > - fd = open(fname, O_RDWR | O_CREAT, S_IRUSR | S_IWUSR | > S_IROTH); > + fd = open(fname, O_RDWR | O_CREAT, 0644 /* rw-r--r-- */); > > if (fd == -1) > return 1; > -- > 1.7.11.7 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
