When someone sends a patch there are a several possible responses: 1) Ack the patch. 2) Request that the submitter redo it. The downside is that no one likes redoing patches. 3) Reject the patch. 4) Redo it yourself and say "Based on a patch from Sachin Kamat". This isn't nice because everyone wants author credit. 5) Redo it and get permission from the original author to give them author credit get their signed-off-by. Your version is better, that's not even a question. It's just that now we're in an awkward place and having long discussions about trivial patches that are going to be re-written anyway. :P regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel