On Wed, Nov 21, 2012 at 02:20:42PM +0100, MAACHE Mehdi wrote: > This bug was introduced in de171bd6ff "Staging: rtl8187se: r8180_wx: fixed a lot of checkpatch.pl issues". > The change log should describe the patch so we don't have to read the code to know what it does. Idealy it would describe the user visible effects of the code, but neither you nor I really know what those are. Here is a better changelog. Please resend with this or something similar. --- Subject: [PATCH v2] Staging: rtl8187se: remove check for IW_ENCODE_DISABLED The original code had a no-op stub where it checked if IW_ENCODE_DISABLED and did nothing. Then in a cleanup patch we accidentally turned the check on. That was: de171bd6ff "Staging: rtl8187se: r8180_wx: fixed a lot of checkpatch.pl issues". The check should just be removed. --- regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
