Re: [PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 20, 2012 at 12:09:57PM +0000, Rupesh Gujare wrote:
> 2. We can save few CPU cycles by checking NULL pointer here, rather
> than relying on kfree().

I'm not sure about that.

But more importantly does any of the memory pools code actually make
a difference in benchmarks?  What is the difference between running
with OZ_MAX_TX_POOL_SIZE as zero and it set to 6?  We have this
very complicated code with spinlocks and linked lists to save six
56 byte allocations...  It's silly.  :P  Just use kmalloc().

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux