On Fri, 2012-11-16 at 18:48 +0100, Samuel Iglesias Gonsálvez wrote: > On Fri, 2012-11-16 at 09:44 -0800, Greg Kroah-Hartman wrote: > > On Fri, Nov 16, 2012 at 06:34:36PM +0100, Samuel Iglesias Gonsalvez wrote: > > > Move ipack header files to include/linux/ directory where they belong to. > > > > > > Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@xxxxxxxxxx> > > > --- > > > drivers/ipack/carriers/tpci200.h | 3 +- > > > drivers/ipack/devices/ipoctal.c | 2 +- > > > drivers/ipack/ipack.c | 2 +- > > > drivers/ipack/ipack.h | 215 -------------------------------------- > > > drivers/ipack/ipack_ids.h | 32 ------ > > > include/linux/ipack.h | 214 +++++++++++++++++++++++++++++++++++++ > > > include/linux/ipack_ids.h | 32 ++++++ > > > 7 files changed, 249 insertions(+), 251 deletions(-) > > > delete mode 100644 drivers/ipack/ipack.h > > > delete mode 100644 drivers/ipack/ipack_ids.h > > > create mode 100644 include/linux/ipack.h > > > create mode 100644 include/linux/ipack_ids.h > > > > Can you send me a patch in -M format, that just shows the files moving > > next time? > > OK > > > Also, do we really need the ipack_ids.h file in include/linux? It looks > > like only the core ipack code cares about the values there, right? > > > > Yes, you are right. I will rewrite the patch again and send it. Looking at the code, 'drivers/ipack/devices/ipoctal.c' needs IPACK1_DEVICE_ID_SBS_OCTAL_* and IPACK_ID_VERSION_1 constants defined in ipack_ids.h file. Is it better to keep ipack_ids.h file in include/linux/ or change the #include sentence? Cheers, Sam
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
