Re: [PATCH 3/3] staging: wlags49_h2: mdd.h: fixes tons of coding style issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 16, 2012 at 06:55:11PM +0200, Johan Meiring wrote:
> This commit sorts out a ton of styling issues, including the use of
> C99 // comments, spaces before and after tabs, etc. I also took the
> time to align stuff a little more neatly using tabs. The file is
> nowhere near ready, but it's a start.
> 
> Signed-off-by: Johan Meiring <johanmeiring@xxxxxxxxx>
> ---
>  drivers/staging/wlags49_h2/mdd.h | 1593 +++++++++++++++++++-------------------
>  1 file changed, 797 insertions(+), 796 deletions(-)

A patch this big is almost impossible to review, sorry.  Please break it
up into smaller pieces.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux