On Wed, Nov 14, 2012 at 01:10:33PM +0000, Ian Abbott wrote: > All the low-level comedi drivers calling `comedi_pci_auto_config()` or > `comedi_usb_auto_config()` define an `auto_attach()` handler in their > `struct comedi_driver`. None of them have an `attach_pci()` or > `attach_usb()` handler any more. This means we can remove those two > handlers and remove a load of code for dealing with the different > methods by which auto-attachment can be accomplished and replace some > exported functions with simple inline wrappers. > > 1) staging: comedi: remove old auto-config > 2) staging: comedi: don't call attach_pci handler > 3) staging: comedi: don't call attach_usb handler > 4) staging: comedi: don't check driver->auto_attach > 5) staging: comedi: simplify comedi_auto_attach() > 6) staging: comedi: remove attach_pci and attach_usb handlers > 7) staging: comedi: use inlines for PCI/USB auto config > > drivers/staging/comedi/comedidev.h | 30 +++++-- > drivers/staging/comedi/drivers.c | 166 +++---------------------------------- > 2 files changed, 32 insertions(+), 164 deletions(-) It's great to see this go away, nice job. greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel