From: Ben Hutchings <ben@xxxxxxxxxxxxxxx> It's silly to create directories without execute permission, or to give permissions to 'other' but not the group-owner. Write the permissions in octal and 'ls -l' format since these are much easier to read than the named macros. Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx> Signed-off-by: Tomas Hozza <thozza@xxxxxxxxxx> --- tools/hv/hv_kvp_daemon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c index 573b9aa..9609858 100644 --- a/tools/hv/hv_kvp_daemon.c +++ b/tools/hv/hv_kvp_daemon.c @@ -236,7 +236,7 @@ static int kvp_file_init(void) int alloc_unit = sizeof(struct kvp_record) * ENTRIES_PER_BLOCK; if (access("/var/lib/hyperv", F_OK)) { - if (mkdir("/var/lib/hyperv", S_IRUSR | S_IWUSR | S_IROTH)) { + if (mkdir("/var/lib/hyperv", 0755 /* rwxr-xr-x */)) { syslog(LOG_ERR, " Failed to create /var/lib/hyperv"); exit(EXIT_FAILURE); } @@ -247,7 +247,7 @@ static int kvp_file_init(void) records_read = 0; num_blocks = 1; sprintf(fname, "/var/lib/hyperv/.kvp_pool_%d", i); - fd = open(fname, O_RDWR | O_CREAT, S_IRUSR | S_IWUSR | S_IROTH); + fd = open(fname, O_RDWR | O_CREAT, 0644 /* rw-r--r-- */); if (fd == -1) return 1; -- 1.7.11.7 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel