Re: [PATCH 2/2] staging: bcm: Bcmchar.c - Checkpatch fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27/10/12 19:23, Dan Carpenter wrote:
On Sat, Oct 27, 2012 at 04:24:41PM +0100, Ceri James wrote:
@@ -1299,7 +1324,10 @@ cntrlEnd:
  			return STATUS_FAILURE;
if (stNVMReadWrite.uiOffset > Adapter->uiNVMDSDSize - stNVMReadWrite.uiNumBytes) {
-			/* BCM_DEBUG_PRINT(Adapter,DBG_TYPE_PRINTK, 0, 0,"Can't allow access beyond NVM Size: 0x%x 0x%x\n", stNVMReadWrite.uiOffset, stNVMReadWrite.uiNumBytes); */
+			/* BCM_DEBUG_PRINT(
+			 * 	Adapter, DBG_TYPE_PRINTK, 0, 0,
+			 * 	"Can't allow access beyond NVM Size: 0x%x 0x%x\n",
+			 * 	stNVMReadWrite.uiOffset, stNVMReadWrite.uiNumBytes); */
I wouldn't have commented except that Greg already did.  The closing
*/ should go on the next line.  Or if you want you could just delete
the this actually.

regards,
dan carpenter

  			return STATUS_FAILURE;
  		}
No problem, I'll add it to  "v2" of this patch set. Cheers.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux