Re: [PATCH 2/2] staging: bcm: Bcmchar.c - Checkpatch fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 27, 2012 at 05:03:38PM +0100, Ceri James wrote:
> On 27/10/12 16:43, Greg KH wrote:
> >On Sat, Oct 27, 2012 at 04:24:41PM +0100, Ceri James wrote:
> >>   This fixes "line over 80 characters" for lines that are "over 140 characters"
> >>   A further patch can be released to fix remaining "line over 80 characters" if necessary.
> >>
> >>   drivers/staging/bcm/Bcmchar.c |  123 ++++++++++++++++++++++++++++++----------
> >>   1 files changed, 92 insertions(+), 31 deletions(-)
> >>
> >>Signed-off-by: Ceri James <jamesceri@xxxxxxxxxxxxxx>
> >>---
> >>  drivers/staging/bcm/Bcmchar.c |  123 ++++++++++++++++++++++++++++++----------
> >>  1 files changed, 92 insertions(+), 31 deletions(-)
> >>
> >>diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
> >>index 1e2a713..a834dac 100644
> >>--- a/drivers/staging/bcm/Bcmchar.c
> >>+++ b/drivers/staging/bcm/Bcmchar.c
> >>@@ -369,7 +369,10 @@ static long bcm_char_ioctl(struct file *filp, UINT cmd, ULONG arg)
> >>  		if ((((ULONG)sWrmBuffer.Register & 0x0F000000) != 0x0F000000) ||
> >>  			((ULONG)sWrmBuffer.Register & 0x3)) {
> >>-			BCM_DEBUG_PRINT(Adapter, DBG_TYPE_PRINTK, 0, 0, "WRM Done On invalid Address : %x Access Denied.\n", (int)sWrmBuffer.Register);
> >>+			BCM_DEBUG_PRINT(
> >>+				Adapter, DBG_TYPE_PRINTK, 0, 0,
> >These two should be on the same line.  Same goes for the others in this
> >file.
> >
> >thanks,
> >
> >greg k-h
> Hi Greg,
> 
> Thanks for the feedback.
> 
> Do you mean that the parameters must remain on the same line as the
> function call, but when they hit the 80 column position then they
> can then be positioned on the next line (within reason)?

Yes.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux