Re: [PATCH 1/2] ipu-v3: ipu-common: Make it less verbose

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 24, 2012 at 09:36:46PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> 
> IPU Interrupt numbers and the various IPU submodules base addresses are more 
> interesting for debugging purposes rather than normal use, so use dev_dbg instead.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>

both:

Acked-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>

Greg, are you taking these directly or do you wish me to collect the
patches and send them to you in a pull request?

Sascha

> ---
>  drivers/staging/imx-drm/ipu-v3/ipu-common.c |   24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-common.c b/drivers/staging/imx-drm/ipu-v3/ipu-common.c
> index f381960..a4de4fa 100644
> --- a/drivers/staging/imx-drm/ipu-v3/ipu-common.c
> +++ b/drivers/staging/imx-drm/ipu-v3/ipu-common.c
> @@ -1006,7 +1006,7 @@ static int __devinit ipu_probe(struct platform_device *pdev)
>  	irq_err = platform_get_irq(pdev, 1);
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  
> -	dev_info(&pdev->dev, "irq_sync: %d irq_err: %d\n",
> +	dev_dbg(&pdev->dev, "irq_sync: %d irq_err: %d\n",
>  			irq_sync, irq_err);
>  
>  	if (!res || irq_sync < 0 || irq_err < 0)
> @@ -1026,27 +1026,27 @@ static int __devinit ipu_probe(struct platform_device *pdev)
>  	spin_lock_init(&ipu->lock);
>  	mutex_init(&ipu->channel_lock);
>  
> -	dev_info(&pdev->dev, "cm_reg:   0x%08lx\n",
> +	dev_dbg(&pdev->dev, "cm_reg:   0x%08lx\n",
>  			ipu_base + devtype->cm_ofs);
> -	dev_info(&pdev->dev, "idmac:    0x%08lx\n",
> +	dev_dbg(&pdev->dev, "idmac:    0x%08lx\n",
>  			ipu_base + devtype->cm_ofs + IPU_CM_IDMAC_REG_OFS);
> -	dev_info(&pdev->dev, "cpmem:    0x%08lx\n",
> +	dev_dbg(&pdev->dev, "cpmem:    0x%08lx\n",
>  			ipu_base + devtype->cpmem_ofs);
> -	dev_info(&pdev->dev, "disp0:    0x%08lx\n",
> +	dev_dbg(&pdev->dev, "disp0:    0x%08lx\n",
>  			ipu_base + devtype->disp0_ofs);
> -	dev_info(&pdev->dev, "disp1:    0x%08lx\n",
> +	dev_dbg(&pdev->dev, "disp1:    0x%08lx\n",
>  			ipu_base + devtype->disp1_ofs);
> -	dev_info(&pdev->dev, "srm:      0x%08lx\n",
> +	dev_dbg(&pdev->dev, "srm:      0x%08lx\n",
>  			ipu_base + devtype->srm_ofs);
> -	dev_info(&pdev->dev, "tpm:      0x%08lx\n",
> +	dev_dbg(&pdev->dev, "tpm:      0x%08lx\n",
>  			ipu_base + devtype->tpm_ofs);
> -	dev_info(&pdev->dev, "dc:       0x%08lx\n",
> +	dev_dbg(&pdev->dev, "dc:       0x%08lx\n",
>  			ipu_base + devtype->cm_ofs + IPU_CM_DC_REG_OFS);
> -	dev_info(&pdev->dev, "ic:       0x%08lx\n",
> +	dev_dbg(&pdev->dev, "ic:       0x%08lx\n",
>  			ipu_base + devtype->cm_ofs + IPU_CM_IC_REG_OFS);
> -	dev_info(&pdev->dev, "dmfc:     0x%08lx\n",
> +	dev_dbg(&pdev->dev, "dmfc:     0x%08lx\n",
>  			ipu_base + devtype->cm_ofs + IPU_CM_DMFC_REG_OFS);
> -	dev_info(&pdev->dev, "vdi:      0x%08lx\n",
> +	dev_dbg(&pdev->dev, "vdi:      0x%08lx\n",
>  			ipu_base + devtype->vdi_ofs);
>  
>  	ipu->cm_reg = devm_ioremap(&pdev->dev,
> -- 
> 1.7.9.5
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux