> -----Original Message----- > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > Sent: Wednesday, October 24, 2012 6:45 PM > To: KY Srinivasan > Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; > apw@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx > Subject: Re: [PATCH 3/3] Drivers: hv: Get rid of hv_ringbuffer_cleanup() > > On Fri, Oct 12, 2012 at 01:22:43PM -0700, K. Y. Srinivasan wrote: > > hv_ringbuffer_cleanup() is an empty function; get rid of it. > > > > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > > Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > > Reported-by: Jason Wang <jasowang@xxxxxxxxxx> > > Acked-by: Jason Wang <jasowang@xxxxxxxxxx> > > --- > > drivers/hv/channel.c | 4 ---- > > drivers/hv/hyperv_vmbus.h | 1 - > > drivers/hv/ring_buffer.c | 11 ----------- > > 3 files changed, 0 insertions(+), 16 deletions(-) > > That's nice, but this patch causes build failures, so I can't accept it. > > Please test your patches better (hint, a simple 'git grep' would have > worked here...) Sorry about that. I am pretty sure I built (with this patch) both vmbus and the util drivers. This function is a private function for the vmbus driver and in fact I went back and rebuilt the drivers in the hv directory without any problem (with this patch applied) in the same tree where I developed these patches (linux-next tree dated October 2, 2012). Specifically, what was the build problem you ran into. Regards, K. Y _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
