Re: [PATCH 00/12] staging: comedi: cleanup the pci vendor ids

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 24, 2012 at 06:10:31PM -0700, H Hartley Sweeten wrote:
> Move all the pci vendor id defines from the drivers to comedidev.h.
> Use the kernel provided vendor ids in pci_ids.h where appropriate.
> 
> The jr3_pci and s626 drivers still have a private PCI_VENDOR_ID_*
> define.
> 
> The jr3_pci vendor id is not found at www.pcidatabase.com.
> 
> The s626 vendor id shows up as belonging to NXP Semiconductor but
> I have not verified that this is the actual chip on that board.
> 
> The skel driver also still has a private PCI_VENDOR_ID_* but it is
> completely bogus.

Nice job with these cleanups.  Eventually we should pus the comedidev.h
values into pci_ids.h as they are in multiple drivers, so that should be
ok.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux