Hi Greg, On Wed, Oct 24, 2012 at 1:37 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Wed, Oct 24, 2012 at 01:23:14AM -0400, Devendra Naga wrote: >> >> These are the patches that remove the typedefs all over the >> csr tree. > > No, only the first patch did that. Not the second two. > yes, i was in a hurry, will fix this. >> there is one .c that is not needed and has no code. > > Not true, see my comment on that patch. > yes, i will see this at later time, but now i am not removing this file. >> and also there are some more function prototypes >> that are defined in the header but there is no function >> definition for those prototypes. > > That patch looked fine. > > Care to redo these based on the comments and resend them? > yes, i will do in a while. > And no real need to do a [RFC] for cleanup patches, just send them, if > something is wrong, we will let you know, I don't want to have to wait > for another round trip to be able to apply them if they are right (like > your third patch here.) > ok, next time i wont put any RFC for cleanups, thanks for the review again :) > thanks, > > greg k-h thanks, _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
