drivers/staging/comedi/drivers/cb_pcidda.c:660 cb_pcidda_attach_pci() warn: variable dereferenced before check 'pcidev' (see line 659)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hartley,

FYI, here is a smatch warning in upstream kernel:

+ drivers/staging/comedi/drivers/cb_pcidda.c:660 cb_pcidda_attach_pci() warn: variable dereferenced before check 'pcidev' (see line 659)

vim +660 drivers/staging/comedi/drivers/cb_pcidda.c

2c0db011 H Hartley Sweeten 2012-08-16 @659  	thisboard = cb_pcidda_find_boardinfo(dev, pcidev);
2c0db011 H Hartley Sweeten 2012-08-16 @660  	if (!pcidev)
2c0db011 H Hartley Sweeten 2012-08-16  661  		return -ENODEV;

It may want to test thisboard rather than pcidev.

---
0-DAY kernel build testing backend         Open Source Technology Center
Fengguang Wu, Yuanhan Liu                              Intel Corporation
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux