Re: [PATCH] Staging: bcm: Checkpatch fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 23, 2012 at 08:59:28PM -0400, Kevin McKinney wrote:
> On Tue, Oct 23, 2012 at 03:50:33PM +0100, Ceri James wrote:
> > This fixes the following checkpatch issues:
> > 
> > WARNING: line over 80 characters
> > +INT InterfaceIdleModeRespond(struct bcm_mini_adapter *Adapter, unsigned int *puiBuffer);
> > 
> > ERROR: "foo * bar" should be "foo *bar"
> > +INT InterfaceWakeUp(struct bcm_mini_adapter * Adapter);
> > 
> > Signed-off-by: Ceri James <jamesceri@xxxxxxxxxxxxxx>
> > ---
> >  drivers/staging/bcm/InterfaceIdleMode.h |    5 +++--
> >  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> Hi Ceri,
> 
> Please submit one patch per warning / error. In this case you will submit two patches. The first patch will fix "Warning: line over 80
> characters". The second patch will fix "foo * bar should be foo *bar".

For a file 12 lines long, this is fine.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux