Re: [PATCH] Staging: bcm: Checkpatch fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 23, 2012 at 09:01:26PM -0400, Kevin McKinney wrote:
> On Tue, Oct 23, 2012 at 01:51:56PM +0100, Ceri James wrote:
> > This fixes the following checkpatch issues:
> > 
> > WARNING: line over 80 characters
> > +	BCM_DEBUG_PRINT(Adapter,DBG_TYPE_TX, TOKEN_COUNTS, DBG_LVL_ALL, "=====>\n");
> > 
> > ERROR: space required after that ',' (ctx:VxV)
> > +	BCM_DEBUG_PRINT(Adapter,DBG_TYPE_TX, TOKEN_COUNTS, DBG_LVL_ALL, "=====>\n");
> >  	                       ^
> > WARNING: line over 80 characters
> > +		BCM_DEBUG_PRINT(Adapter,DBG_TYPE_TX, TOKEN_COUNTS, DBG_LVL_ALL, "Adapter found NULL!\n");
> > 
> > ERROR: space required after that ',' (ctx:VxV)
> > +		BCM_DEBUG_PRINT(Adapter,DBG_TYPE_TX, TOKEN_COUNTS, DBG_LVL_ALL, "Adapter found NULL!\n");
> >  		                       ^
> 
> Same here, submit one patch per warning / error.

What?  No, this is a simple patch, it is fine, don't drag it out even
more than needed.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux