Re: [PATCH 3/9] staging: comedi: change type of auto-config context

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20/10/12 04:44, Dan Carpenter wrote:
On Mon, Oct 15, 2012 at 01:07:33PM +0100, Ian Abbott wrote:
Change the type of the context parameter passed to
`comedi_auto_config_helper()` from `void *` to `unsigned long`.  It's
currently just an internal change and all current internal usages pass
pointers in the context, but future uses of this function may pass
                                                             ^^^
integer values

"May?"  Don't make this kind of change until you have a user ready.
Using an unsigned long is uglier than using a void pointer so let's
not do it until it is needed.

Obviously the same thing would apply to the other places.

Patch 6 passes an unsigned integer value in the context. In the end, the context probably won't be used much, but it's handy to have it in case it's needed.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux